Removes .nvmrc; gitignores .nvmrc and .tool-versions

selfdefined / web-app

Dictionary database with future API and bot integrations

https://www.selfdefined.app/

573 stars 172 forks source link

Removes .nvmrc; gitignores .nvmrc and .tool-versions #410

Closed mpcsh closed 3 years ago

mpcsh commented 3 years ago

See #404 for context, specifically this comment and this comment

ovlb commented 3 years ago

Hey. We should not remove these files, as they configure different tools to use the correct NPM version. To avoid errors in the build we should make sure that all contributors use the same NPM version not configure them as they see fit.

ovlb commented 3 years ago

For context: we had some issues with folx using NPM versions that were all over the place and dependencies that failed in these versions. Since we added the tool files to have canonical versioning.

mpcsh commented 3 years ago

Fair enough! See #412