Extract Home Assistant API code to its own published crate - Githubissues

selfhostedshow / halcyon

Home Assistant Linux Companion

https://halcyon.casa/

45 stars 4 forks source link

Extract Home Assistant API code to its own published crate #16

Closed kylepotts closed 3 years ago

kylepotts commented 3 years ago

To keep some of the project clean, we should move the home assistant api code to an external crate for others to use if they want to.

ironicbadger commented 3 years ago

Not knowing fully what a crate is, does this effectively make the API integration code into a reusable component? If so, that sounds great.

BCNelson commented 3 years ago

Done Selfhostedshow/ha_api

RealOrangeOne commented 3 years ago

There already appears to be a HA API library on crates.io: https://crates.io/search?q=home-assistant

I'd be interested in either trying to reuse that library, or potentially upstream our changes to it.

BCNelson commented 3 years ago

That one has been unmaintained for several years and the library does not support the mobile app api. I agree thought upstreaming would be better. I looked for the maintainers contact info but could not find it. Maybe mentioning them will get there attention @kpcyrd

kpcyrd commented 3 years ago

I don't see myself maintaining my old crate in the future, but I would be fine with adding new maintainers to the repo and have the codebase replaced. :)

BCNelson commented 3 years ago

@kpcyrd Perfect, thank you. As I see it we have two options.

As you suggested add some people as maintainers on the repo and have the code base replaced.
Transfer the crates.io namespace to us and we create the repo under the selfhostedshow organization

Ether works for us but the second is ideal if you aren't planning on getting involved.

kpcyrd commented 3 years ago

If possible I'd prefer transferring the crates.io namespace to somebody involved with the home-assistant org who would then add you as additional owners. That way home-assistant is able to add new maintainers if the crate stales for whatever reason. :)

BCNelson commented 3 years ago

Any ideas on who we should contact in the Home Assistant Org?

kpcyrd commented 3 years ago

I've pinged them on twitter, in the meantime I can already add you as owner, I'd just prefer to have somebody from homeassistant as a co-owner before I remove myself from the namespace.

kpcyrd commented 3 years ago

I've checked and they don't seem concerned, what are your crates.io usernames?

BCNelson commented 3 years ago

bcnelson