search

selfhostedshow / wiki

The official Wiki of the selfhosted.show Podcast.
https://wiki.selfhosted.show
GNU General Public License v3.0
197 stars 61 forks source link

Remove duplicate of beginners-contributing-guide from basic #88

Closed Bas-Man closed 3 years ago

Bas-Man commented 3 years ago

This closes #85

Though I would still like to have people making their changes in a new branch based off master. This would protect their local master branch. In the advent that their pull requests are not accepted, or take a long time to be accepted. I can foresee people having potential merge conflicts down the road.

Something along the lines of

git checkout -b <my contribution>

Then after edits.

git push <my contribition>

What are you thoughts @WhiteNight121

RealOrangeOne commented 3 years ago

The link to this page should also be removed from the CONTRIBUTING.md file too.

Bas-Man commented 3 years ago

I will take a look at it in a few hours. Thanks for catching that issue.

Bas-Man commented 3 years ago

The link to this page should also be removed from the CONTRIBUTING.md file too.

This is actually already correct and does not need to be changed. It already correctly references content in the docs/wiki/ folder.

But I have found another issue contained within the beginners-contributing-guide.

#### 1.3 Merging an local repository into your Fork

This Section will "merge" the local changes to your fork (your github repo that was made above in [section 1.1](https://github.com/selfhostedshow/wiki/tree/master/docs\basics/beginners-contributing-guide/#11-fork-clone-the-self-hosted-show-wiki))

This link is broken; even in the exist live site. Will investigate. Since I am not sure what this content was.

Bas-Man commented 3 years ago

The link to this page should also be removed from the CONTRIBUTING.md file too.

This is actually already correct and does not need to be changed. It already correctly references content in the docs/wiki/ folder.

But I have found another issue contained within the beginners-contributing-guide.

#### 1.3 Merging an local repository into your Fork

This Section will "merge" the local changes to your fork (your github repo that was made above in [section 1.1](https://github.com/selfhostedshow/wiki/tree/master/docs\basics/beginners-contributing-guide/#11-fork-clone-the-self-hosted-show-wiki))

This link is broken; even in the exist live site. Will investigate. Since I am not sure what this content was.

I think I have resolved this internal issue with the latest commit.