selfhosters / unRAID-CA-templates

An Unraid community repo where you can request unRAID container templates to be added to Community Applications: Squidly271/community.applications.
MIT License
150 stars 83 forks source link

CA Template Request - YoutubeDL-Material #92

Closed GlassedSilver closed 4 years ago

GlassedSilver commented 4 years ago

Please add the dockerhub repo link and github/gitlab link below Docker Hub: https://hub.docker.com/r/tzahi12345/youtubedl-material/ Github: https://github.com/Tzahi12345/YoutubeDL-Material

Post any additional information about the project that you know is important

Tried to make a container myself, but unfortunately this being my first time experimenting with this, I think I didn't succeed.

If desired, I can attach my xml for you guys to look into so maybe in the future I know what I may have missed and contribute as well, until then I'd be super thankful for someone else picking up the slack?

The container allows for an advanced download mode to be enabled or disabled. I'd STRONGLY suggest we overwrite the default of "false", because this container having more options is kinda the key differentiator.

The variable for this would be "allow_advanced_download".

GlassedSilver commented 4 years ago

Well this would be my xml, I didn't make it pretty like removing unnecessary segments, would certainly bother doing that if I were to publish this for others to use.

Stuff like DateInstalled and the like. Also my custom paths that I tried it with.

<?xml version="1.0"?>
<Container version="2">
  <Name>youtubedl-material</Name>
  <Repository>tzahi12345/youtubedl-material</Repository>
  <Registry>https://hub.docker.com/r/tzahi12345/youtubedl-material/</Registry>
  <Network>bridge</Network>
  <MyIP/>
  <Shell>sh</Shell>
  <Privileged>false</Privileged>
  <Support/>
  <Project>https://github.com/Tzahi12345/YoutubeDL-Material</Project>
  <Overview>YoutubeDL-Material is a self-hosted youtube-dl Server with a modern Material-based GUI and the capability to apply advanced configurations, like setting your own download paths based on rules.&#xD;
&#xD;
It is designed to be more customizable than the alternatives out there.&#xD;
&#xD;
It will also keep a record of already downloaded items. Enjoy! :)</Overview>
  <Category>Downloaders: MediaApp:Video MediaApp:Music Status:Beta</Category>
  <WebUI>http://[IP]:[PORT:8998]/</WebUI>
  <TemplateURL/>
  <Icon>https://cdn3.iconfinder.com/data/icons/capsocial-round/500/youtube-512.png</Icon>
  <ExtraParams/>
  <PostArgs/>
  <CPUset/>
  <DateInstalled>1583136524</DateInstalled>
  <DonateText/>
  <DonateLink/>
  <Description>YoutubeDL-Material is a self-hosted youtube-dl Server with a modern Material-based GUI and the capability to apply advanced configurations, like setting your own download paths based on rules.&#xD;
&#xD;
It is designed to be more customizable than the alternatives out there.&#xD;
&#xD;
It will also keep a record of already downloaded items. Enjoy! :)</Description>
  <Networking>
    <Mode>bridge</Mode>
    <Publish>
      <Port>
        <HostPort>17442</HostPort>
        <ContainerPort>8998</ContainerPort>
        <Protocol>tcp</Protocol>
      </Port>
    </Publish>
  </Networking>
  <Data>
    <Volume>
      <HostDir>/mnt/user/Downloads/youtube-dl-test/audio/</HostDir>
      <ContainerDir>/audio/</ContainerDir>
      <Mode>rw</Mode>
    </Volume>
    <Volume>
      <HostDir>/mnt/user/Downloads/youtube-dl-test/video/</HostDir>
      <ContainerDir>/video/</ContainerDir>
      <Mode>rw</Mode>
    </Volume>
  </Data>
  <Environment>
    <Variable>
      <Value>YoutubeDL Material</Value>
      <Name>ytdl_title_top</Name>
      <Mode/>
    </Variable>
    <Variable>
      <Value>true</Value>
      <Name>ytdl_allow_advanced_download</Name>
      <Mode/>
    </Variable>
  </Environment>
  <Labels/>
  <Config Name="WebUI" Target="8998" Default="17442" Mode="tcp" Description="Container: 8998" Type="Port" Display="always" Required="true" Mask="false">17442</Config>
  <Config Name="Audio Downloads" Target="/audio/" Default="" Mode="rw" Description="Container Path: /audio/" Type="Path" Display="always" Required="true" Mask="false">/mnt/user/Downloads/youtube-dl-test/audio/</Config>
  <Config Name="Video Downloads" Target="/video/" Default="" Mode="rw" Description="Container Path: /video/" Type="Path" Display="always" Required="true" Mask="false">/mnt/user/Downloads/youtube-dl-test/video/</Config>
  <Config Name="WebUI Title" Target="ytdl_title_top" Default="" Mode="" Description="Container Variable: ytdl_title_top" Type="Variable" Display="always" Required="false" Mask="false">YoutubeDL Material</Config>
  <Config Name="Advanced Configuration Mode" Target="ytdl_allow_advanced_download" Default="true" Mode="" Description="Allow advanced configuration (true/false)" Type="Variable" Display="advanced" Required="false" Mask="false">true</Config>
</Container>
Roxedus commented 4 years ago

Your XML is pretty much there, there is still a few things you can do. https://selfhosters.net/docker/templating/templating/#114-shave-off-the-xml

GlassedSilver commented 4 years ago

I checked back with the dev of the application. It is in working state now after some fixes.

I will test the container now myself for a short time, wait for a new version maybe with some fixes and improvements that I would consider smart to wait for an initial release for the CAs and eventually make a PR. :)

Edit: Just to let everyone know: I am not abandoning this. I'm told by the dev that the next version (which I target for a beta CA release) is a few weeks away. :)