search

selfrefactor / rambda

Faster and smaller alternative to Ramda
https://selfrefactor.github.io/rambda
MIT License
1.65k stars 89 forks source link

fix: takeLastWhile didn't stop on its own #666

Closed agriffis closed 1 year ago

agriffis commented 1 year ago

The test which supposedly tested this depended on the predicate returning false eventually.

agriffis commented 1 year ago

Actually I'll push another commit to clean up the approach for dropWhile, takeWhile, dropLastWhile, takeLastWhile

selfrefactor commented 1 year ago

this looks bad from my side. I will approve and take a closer look later but if you are right, I have to merge with Thank you and no questions.

selfrefactor commented 1 year ago

BTW, you don't need new commit for the other methods as I will check them myself.

agriffis commented 1 year ago

I have the commit already, so I'll give you a PR and you can decide what you want to do.

agriffis commented 1 year ago

Whenever you can make a release with this fix in particular, that would be appreciated. It's a bit awkward to work around it!