search

selfrefactor / rambda

Faster and smaller alternative to Ramda
https://selfrefactor.github.io/rambda
MIT License
1.65k stars 89 forks source link

perf: faster equals with Object.is short circuit #725

Closed agriffis closed 8 months ago

agriffis commented 8 months ago

It seems like R.equals does a lot of work even if passed the same reference, for example:

const x = {/* big structure */}
R.equals(x, x) // does deep compare

Is there a reason that it doesn't have an Object.is short-circuit?

selfrefactor commented 8 months ago

Thanks for this MR As I am working on other things, new release will be made sometime next week.

agriffis commented 8 months ago

Thank you! I'm looking forward to the release.

agriffis commented 7 months ago

@selfrefactor Are you still planning on a release soon?

selfrefactor commented 7 months ago

released with 9.1.1; txs for reminder

agriffis commented 7 months ago

Thanks! I put a comment on #726 and #727 because I think there might be a problem, but otherwise, I'm looking forward to this in rambdax since that's what I actually use :sweat_smile:

selfrefactor commented 7 months ago

I will release next week as I will be offline for a while. Txs for patience!