corrected implementation of unless function

[orangebokov]

This is a type definition from node_modules/rambda/index.d.ts

export function unless<T, U>(predicate: (x: T) => boolean, whenFalseFn: (x: T) => U, x: T): T | U;
export function unless<T, U>(predicate: (x: T) => boolean, whenFalseFn: (x: T) => U): (x: T) => T | U;
export function unless<T>(predicate: (x: T) => boolean, whenFalseFn: (x: T) => T, x: T): T;
export function unless<T>(predicate: (x: T) => boolean, whenFalseFn: (x: T) => T): (x: T) => T;

This is implementation from node_modules/rambda/src/unless.js

export function unless(predicate, whenFalse){
  if (arguments.length === 1){
    return _whenFalse => unless(predicate, _whenFalse)
  }

  return input => predicate(input) ? input : whenFalse(input)
}

The problem that this incorrectly works with 3 parameters. Example:

export const getCurrentURL = () => unless(startsWith('/'), concat('/'), window.location.pathname)

This should return the string. But it returns the function: input => predicate(input) ? input : whenFalse(input) Which is not surprising based on the implementation

The when function works great An example of correct implementation based on the when function:

import { curry } from './curry.js'

function unlessFn(predicate, whenFalseFn, input){
  if (predicate(input)) return input

  return whenFalseFn(input)
}

export const unless = curry(unlessFn)

[selfrefactor]

thanks for this change. I will notify once it is released.

[orangebokov]

thanks for the library

[agriffis]

I think this was broken by #727 somehow

[selfrefactor]

should be fixed with 9.2.0

[agriffis]

@selfrefactor rambdax release too?

[selfrefactor]

Sorry for delay, 11.1.0 for Rambdax was just released