search

selfthinker / dokuwiki_plugin_wrap

Wrap Plugin for DokuWiki: Universal plugin which combines functionalities of many other plugins. Wrap wiki text inside containers (divs or spans) and give them a class (choose from a variety of preset classes), a width and/or a language with its associated text direction.
http://www.dokuwiki.org/plugin:wrap
GNU General Public License v2.0
41 stars 33 forks source link

Fix deprecation warnings #243

Closed fiwswe closed 1 year ago

fiwswe commented 2 years ago

Fixes #242

Works under Hogfather and Igor.

Klap-in commented 2 years ago

This will break the older Greebo version, because _addCall was refactored in Hogfather. For most plugins I would merge it already, but the Wrap plugin is one of the most used plugins. So I expect therefore relative more not yet updated installations are using it. @selfthinker do you prefer longer backward compatibility, more than two releases?

fiwswe commented 2 years ago

I don't have any idea which versions are in actual use. But my 2¢ are: Hogfather is still important, while everything gets fixed and updated for Igor and PHP 8. Greebo not so much.

Looking at it from a different perspective: Hogfather was released more than 2 years ago. Dropping support for older systems should be acceptable.

But if required we could adjust the fix to differentiate between DW versions. Ugly and it opens a huge can of worms IMHO.

Plugin and Theme metadata and distribution lacks a mechanism to define DW compatibility. Or a mechanism to offer different versions for different DW versions. So when the DW API changes, there tend to be issues. Not sure if adding such a mechanism would be worthwhile. Something like that has the potential to add a lot of complexity for something not very important.

splitbrain commented 1 year ago

I would agree Hogfather compatibility is enough. People who do not upgrade their wiki usually do not upgrade their plugins either ;-)

@selfthinker can we get this merged?