search

selfthinker / dokuwiki_plugin_wrap

Wrap Plugin for DokuWiki: Universal plugin which combines functionalities of many other plugins. Wrap wiki text inside containers (divs or spans) and give them a class (choose from a variety of preset classes), a width and/or a language with its associated text direction.
http://www.dokuwiki.org/plugin:wrap
GNU General Public License v2.0
42 stars 33 forks source link

Tabs are not rendered #249

Open UlviShukurzade opened 1 year ago

UlviShukurzade commented 1 year ago

Tabs are not rendering and it just shows list of links

fiwswe commented 1 year ago

Are you talking about U+0009 HTAB characters? Or are you talking about the <WRAP tabs> Syntax?

Please provide more details, such as the relevant page source. What would be your expectation and what are you seeing? And why would this be relevant to the Wrap Plugin?

FWIW: The following works fine here:

<WRAP tabs>
  * [[test:page1|Test Page #1]]
  * [[test:page2|Test Page #2]]
  * [[test:page3|Test Page #3]]
  * [[https://dokuwiki.org|DokuWiki]]
</WRAP>

DokuWiki 2022-07-31a "Igor", Wrap Plugin (Last updated on 2022-08-10), sprintDoc Template (Last updated on 2023-03-02)

Note: I'm not sure what the tabs feature is good for as the tabs don't work like real tabs, i.e. switch between different content panes. They are just links rendered a bit differently. And if you give it a hierarchical list of links it gets really weird. I would not mind if this feature was removed.

Oh and btw: did you maybe use <wrap tabs> instead of <WRAP tabs>? The former produces a <span> element which is inline and not suited for rendering tabs. The later produces a <div> (a block element).

UlviShukurzade commented 1 year ago

dear @fiwswe thank you for your detailed post. I exactly did the same image but the output is different. it just lists. there is bootswrapper version of tabbing. can you check it and let me know if it works on your environment with "igor" version? it is used like this 

<tabs type="tabs">
      * [[#tab-abstract|Abstract]]
      * [[#tab-recent|Recent updates]]
      * [[#tab-first-year|First year summary]]

    <pane id="tab-abstract">
        **Abstract**\\
    </pane>

    <pane id="tab-recent">
        **recent**\\
    </pane>

    <pane id="tab-first-year">
        **first update**\\
    </pane>
</tabs>

this is very elegant way. but reason I am trying to work with WRAP tabs is , the bootswrapper version is not vorking with igor. can you please check let me know?

fiwswe commented 1 year ago

Ok, this is slightly off-topic here, but for testing I have installed the Bootstrap Wrapper Plugin (Last updated on 2022-09-22) and tried your example:

It does not work! (No tabs just a hierarchical list and a leftover </tabs> and other tags displayed. Three edit buttons for the panes which are not displayed as such):

image

Note that DW is running with PHP 8.0.24 and I'm using Safari Version 16.3 (macOS 13.2.1) in case that might make any difference.

I'll remove the Bootstrap Wrapper Plugin now, as I don't think I need what it is supposed to do — especially if it doesn't work ;-).

UlviShukurzade commented 1 year ago

Thank you for testing! I though it might be same reason why both does not work. I wanted to alter with . and it did not work. wanted to open an issue. now it is more certain that, our environment (server) have some problems as WRAP tab works on your system.

UlviShukurzade commented 1 year ago

but WRAP tab still does not work on our page

fiwswe commented 1 year ago

This is what my <WRAP tabs> example from above looks like in my Wiki:

image

The only slight issue is the icon displayed for the external link. Probably needs some CSS tweaking…

Could there be some interaction with other plugins/templates you are using? My list looks like this:

Installed Plugins:

Installed Templates: