search

selfthinker / dokuwiki_plugin_wrap

Wrap Plugin for DokuWiki: Universal plugin which combines functionalities of many other plugins. Wrap wiki text inside containers (divs or spans) and give them a class (choose from a variety of preset classes), a width and/or a language with its associated text direction.
http://www.dokuwiki.org/plugin:wrap
GNU General Public License v2.0
41 stars 33 forks source link

Fix ODT exporting tables #274

Open eduardomozart opened 9 months ago

eduardomozart commented 9 months ago

Fixes #272

nerun commented 9 months ago

It fails in 4 tests and you changed null to 0cm, maybe "null" works better.

eduardomozart commented 9 months ago

It shouldn't be null because null isn't a valid CSS value for margin. In fact, if you see the lines 710-717, you'll see that for the problem you're facing (float is null), the code set the margins to 0cm. I just set it directly to 0cm to avoid code changes, but you're free to change the float detection and variable assignments if you will and commit a PR to the code.

nerun commented 9 months ago

Submited PR #275, but same errors, same tests.