search

selfthinker / dokuwiki_template_writr

Bold, minimalist and modern DokuWiki template, converted from the Writr WordPress theme
https://www.dokuwiki.org/template:writr
GNU General Public License v2.0
50 stars 16 forks source link

Committing all the changes from Writr2 to prepare for Writr Adoption #29

Closed LouisOuellet closed 1 day ago

LouisOuellet commented 10 months ago

Committing all the changes from Writr2 to prepare for Writr Adoption

selfthinker commented 10 months ago

I would usually never consider a Pull Request that is so big. But because we've had conversations about these changes before I'll make an exception. You might still want to make several PRs out of this to make it easier and faster to merge them.

I will start giving feedback to your changes. Although I will probably not be done in one go and will need tomorrow as well. Not all of my feedback will have the same weight. I will sometimes introduce something with the word "Minor" to make it clear that it's not as important as the other feedback.

One general thing is that you are mixing indentation styles. I recommend installing an EditorConfig plugin for your IDE. Core DokuWiki comes with an .editorconfig file which can be used but you can also add your own to this repo. (I usually do that in later projects.)

selfthinker commented 10 months ago

And I'm done and actually managed to finish this in one go. Let me know if you have any questions.

LouisOuellet commented 9 months ago

I would usually never consider a Pull Request that is so big. But because we've had conversations about these changes before I'll make an exception. You might still want to make several PRs out of this to make it easier and faster to merge them.

Yeah I pushed all the changes I had made on my website.

I will start giving feedback to your changes. Although I will probably not be done in one go and will need tomorrow as well. Not all of my feedback will have the same weight. I will sometimes introduce something with the word "Minor" to make it clear that it's not as important as the other feedback.

Great.

One general thing is that you are mixing indentation styles. I recommend installing an EditorConfig plugin for your IDE. Core DokuWiki comes with an .editorconfig file which can be used but you can also add your own to this repo. (I usually do that in later projects.)

I am using Microsoft Visual Studio Code. Indenting with tabs showing as 4 spaces. Just load the extension and created the .editorconfig from the repo dokuwiki/dokuwiki.

LouisOuellet commented 9 months ago

Made almost all the requested changes. Just need to patch and commit.

LouisOuellet commented 8 months ago

Answered your comments and modified my local code, just need to commit and push now.

LouisOuellet commented 8 months ago

Ok so I have pushed the last couples of commits. I think all that is left here is the discussion on namespace logo. This was a feature request that I wanted to implement as I could easily see the use case. So I thought why not. But before completing this, I'll have to read a little bit more about the tpl_getMediaFile function. That is to make sure I am using it correctly. Plus I need to review the array provided so that it correctly and recursively add the namespaces.

[EDIT] Actually maybe you could help me by pointing me in the right direction. I am looking into the repository Dokuwiki/Dokuwiki, I am having difficulties finding the function in question. I found this old commit : 27833958 from 2012. In feed.php. But it seems that file has been updated a lot since then.

[EDIT] Nevermind, just found API documentation. Was able to add the necessary code to enable support of namespace logos