search

selfup / hyperapp-one

Hyperapp One is a Parcel boilerplate for quickstarting a web application with Hyperapp (V1), JSX, and Prettier.
https://selfup.github.io/hyperapp-one
MIT License
126 stars 20 forks source link

chore: update deps #37

Closed brycemcwilliams closed 6 years ago

selfup commented 6 years ago

First of all thanks :pray:

If we move compiled assets to dist we can no longer deploy to github pages :thinking:

Unless we change the public path to dist and refer to that path in the index.html after moving the html file back to root

Let me know what you think

brycemcwilliams commented 6 years ago

No problem bro,

I normally use something like the following:

Deploy

git subtree split --prefix dist -b gh-pages
git push -f origin gh-pages:gh-pages
git branch -D gh-pages

What are your thoughts? You could add as a script? 🤔

selfup commented 6 years ago

Yea adding as a script could work!

Let me try this out when I get home today.

I wouldn't mind making a script directory 👍

selfup commented 6 years ago

Could you also update Hyperapp to 1.2.5? Thanks 🙏

selfup commented 6 years ago

And If you can just update the instructions in the README on how to deploy to GH pages that would be great 👍

selfup commented 6 years ago

Once you update the README and upgrade to HA 1.2.5, I am down to merge 😄

brycemcwilliams commented 6 years ago

Sweet have done as requested, let me know what you think 👍

selfup commented 6 years ago

Sweet! Looks good. Tests pass 🎉