selfuryon / netdev

Asynchronous multi-vendor library for interacting with network devices
http://netdev.readthedocs.io/
Apache License 2.0
213 stars 45 forks source link

await send_command not accepting 'use_textfsm=True' #15

Open walidamer711 opened 5 years ago

walidamer711 commented 5 years ago

While trying add use_textfsm=True to send_commad function it raises the below error.

Traceback (most recent call last): File "async-ssh.py", line 51, in main() File "async-ssh.py", line 46, in main print(task.result()) File "async-ssh.py", line 30, in collect_output command_result = await connection.send_command(command,use_textfsm=True) TypeError: send_command() got an unexpected keyword argument 'use_textfsm' Task exception was never retrieved future: <Task finished coro=<collect_output() done, defined at async-ssh.py:24> exception=TypeError("send_command() got an unexpected keyword argument 'use_textfsm'",)> Traceback (most recent call last): File "async-ssh.py", line 30, in collect_output command_result = await connection.send_command(command,use_textfsm=True) TypeError: send_command() got an unexpected keyword argument 'use_textfsm'

selfuryon commented 5 years ago

Hello, @walidamer711 ! My library doesn't support textfsm, but it's interesting. What do you expect from using this args "use_textfsm=True"?

walidamer711 commented 5 years ago

Hello, In reference to the below link, netmiko now support passing this parameter "use_textfsm=True" along with send_command() in order to return structured data parsed with ready textfsm templates created in ntc-templates. So it is all about getting structured data.

https://pynet.twb-tech.com/blog/automation/netmiko-textfsm.html

if you can add this to your library, that will be great. Thanks

selfuryon commented 5 years ago

Oh, it's a great idea! I will realize it in the next release!

Ali-aqrabawi commented 5 years ago

@selfuryon i'm interested to work on this, you can assign it to me.

selfuryon commented 5 years ago

Related PR #33