search

selimsami / qforce

Apache License 2.0
57 stars 13 forks source link

Try to fix codecov #30

Closed xiki-tempula closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #30 (b73aada) into master (3142e36) will increase coverage by 46.36%. The diff coverage is n/a.

xiki-tempula commented 2 years ago

@selimsami I have added a temporal fix to the codecov where I had https://github.com/selimsami/qforce/blob/0fa505782eaa35cc5c2afbb084d137d66e3db4d8/.github/workflows/CI.yaml#L52 changed to python -m pip install -e . I have no idea why it won't work without the -e but at least the code coverage is working fine now.

selimsami commented 2 years ago

Hi @xiki-tempula , I made some changes to the CI implementation and managed to fix the requirement for pip install -e.

Main problem was that tests directory was missing __init__.py and some relative imports after fixing that.

Have a look at the main branch and let me know if you have any suggestions.

This PR is no longer needed.

xiki-tempula commented 2 years ago

@selimsami Excellent, it seems to me that the changes are fine. Let's see if the build will succeed.