search

seliopou / elm-d3

Elm bindings for D3.js
Other
335 stars 36 forks source link

Scales, Axes, and a bar graph #11

Closed michaelbjames closed 10 years ago

michaelbjames commented 10 years ago

I've created the infrastructure to make bar graphs at least, if not more kinds of graphs. I had to port scales over to elm-d3 and axes, too.

seliopou commented 10 years ago

First pass, the Axis implementation still needs to be rejiggered a bit. Do you mind splitting this up into two pull requests: one for scales and one for axes? Scales will be able to be merged much quicker, but I still need to review it.

michaelbjames commented 10 years ago

Yeah sure. What part(s) of Axes bother you?

michaelbjames commented 10 years ago

See https://github.com/seliopou/elm-d3/pull/12

The axis pull request will change depending on updates to scales, so I think it's simplest to do them sequentially.