seliver / ElpisRemote

Remote Control for Elpis
GNU General Public License v3.0
8 stars 5 forks source link

Feature Request: Visual Indication of current Like/Dislike (Thumbs Up/Down) State #5

Open EnigmaSolved opened 9 years ago

EnigmaSolved commented 9 years ago

In the little bit that I've used ElpisRemote I don't think there is any indication of current Like/Dislike (Thumbs Up/Down) state of the playing song. Once Thumbs Up and Thumbs Down icons are added to the UI, the respective Thumb should be highlighted if the current song has a Liked/Disliked state.

Because Elpis (desktop) allows you to remove a Thumb state (ie, undo/remove a Like or a Dislike without having to choose the opposite, but rather just return the state to neutral) I am nervous about using the Like/Dislike buttons in the current version of ElpisRemote (1.0.1) because I don't want to remove a Like by Liking a song again (and since there's not visual indicator of the state in ElpisRemote I just end up doing nothing). I really like the feature in Elpis (desktop) of being able to revert a Thumbs Up/Down back to neutral, and I suggest that ElpisRemote work the same way (and since it is just passing commands to Elpis desktop my expectation is that it already works this way, but just lacking the visual feedback).

seliver commented 9 years ago

Well, for now you can distinguish if you liked or not the song by looking at the Like button text. If it says "Like", you haven't liked it, if it says "Liked", you did.

Alexey

On 04/03/2015 20:25, Sean Slevin wrote:

In the little bit that I've used ElpisRemote I don't think there is any indication of current Like/Dislike (Thumbs Up/Down) state of the playing song. Once Thumbs Up and Thumbs Down icons are added to the UI, the respective Thumb should be highlighted if the current song has a Liked/Disliked state.

Because Elpis (desktop) allows you to remove a Thumb state (ie, undo/remove a Like or a Dislike without having to choose the opposite, but rather just return the state to neutral) I am nervous about using the Like/Dislike buttons in the current version of ElpisRemote (1.0.1) because I don't want to /remove/ a Like by Liking a song again (and since there's not visual indicator of the state in ElpisRemote I just end up doing nothing). I really like the feature in Elpis (desktop) of being able to revert a Thumbs Up/Down back to neutral, and I suggest that ElpisRemote work the same way (and since it is just passing commands to Elpis desktop my expectation is that it already works this way, but just lacking the visual feedback).

— Reply to this email directly or view it on GitHub https://github.com/seliver/ElpisRemote/issues/5.

EnigmaSolved commented 9 years ago

Ah, I missed that! Excellent! That's a great (text-based) approach for the time being! :)