search

selkamand / ggoncoplot

Easily Create Interactive Oncoplots
https://selkamand.github.io/ggoncoplot/
Other
3 stars 0 forks source link

Add data_id to ggoncoplot_prep_df returned dataframes and add test #21

Closed selkamand closed 2 years ago

selkamand commented 2 years ago

Current tests

# Check dataframe has required names
  expect_named(prepped_df, expected = c('Sample', 'Gene', 'MutationType', 'Tooltip'), ignore.order = TRUE)
  expect_named(prepped_df_no_mutation_type, expected = c('Sample', 'Gene', 'MutationType', 'Tooltip'), ignore.order = TRUE)

Should we add test for data_id column

selkamand commented 2 years ago

No. data_id for ggiraph calls will ALWAYS be the same as 'Sample' so we don't need add a column with this redundant information. Better to keep the returned dataframe as simple as possible