selkamand / ggoncoplot

Easily Create Interactive Oncoplots
https://selkamand.github.io/ggoncoplot/
Other
3 stars 0 forks source link

Unify look and scale of ggplot vs ggiraph #47

Closed selkamand closed 4 months ago

selkamand commented 1 year ago

The interactive plot looks great, however the static plot looks terrible, as the readme shows.

I think if we can get the default sizing of interactive plots right, we should be able to have interactive plots that look very similar to static plots. This would make development much easier since a nice looking interactive plot should also be a nice looking oncoplot

Worst case scenario - this proves difficult and we need to change legend position / orientation / ncol /nrow for statics - but I'm fairly confident we should be able to avoid this with a much cleaner solution

selkamand commented 1 year ago

Also consider differences in fonts between ggiraph and ggplot

selkamand commented 4 months ago

In current versions, static plots look good to me. Readme static plots also look better now that chunk figure dimensions are set to something sensible