selkamand / sigstash

Easily load published mutational signatures into R
Other
0 stars 0 forks source link

Consider dropping hash-based identification #51

Open selkamand opened 1 month ago

selkamand commented 1 month ago

Now that we've added #47 and attribute based identification to sig_identify_collection(), should we drop the digest-package dependent hash based identification?

Pros:

Cons:

selkamand commented 1 month ago

We already have:

sigstash::sig_read_signatures()
sigstash::sig_write_signatures()

We should add attributes addition to sig_read_signatures()