search

selkamand / sigstats

Mathematical Operations and Transformations for Sigverse Signatures and Catalogues
https://selkamand.github.io/sigstats/
Other
0 stars 0 forks source link

Add tolerance to assertions about model sums #18

Closed selkamand closed 4 months ago

selkamand commented 4 months ago

Wondering if the following assertion in sig_combine is too strict

assertions::assert(sum(model) <= 1, msg = "Contributions of all signatures in model should add up to <= 1, not [{sum(model)}]")

For example it throws the error: Contributions of all signatures in model should add up to <= 1, not [1]

When the signature model added up to: 1.000000000000000444089