selkamand / sigstats

Mathematical Operations and Transformations for Sigverse Signatures and Catalogues
https://selkamand.github.io/sigstats/
Other
0 stars 0 forks source link

Add option in to export the output of sig_combine as a single signature #3

Closed selkamand closed 5 months ago

selkamand commented 5 months ago

by default sig_combine() outputs data in the combined_signature_model format (where contributions from each originating signature are kept separate at the cost of duplicated rows for each channel). This format is great for plotting with sig_visualise in model mode, but collapsing the model down to a single signature representing the combination of many others is much more useful for operations like simulating catalogues from the model.

For this reason, we implemented sig_combine_collapse_to_single_signature() that you can pipe the results into, but i think exposing an argument of sig_combine (e.g. format = c("combined_signature_model", "signature")) that automatically calls sig_combine_collapse_to_single_signature() would be more intuitive.