search

selkhateeb / hardlink

a simple command-line utility that implements hardlinks on Mac OsX
486 stars 45 forks source link

Hey a request #21

Closed jasonsyoung closed 9 years ago

jasonsyoung commented 9 years ago

I tried creating a homebrew formula out of your binary but was unable to get it accepted as the owner would rather you modify your repository and then add the ruby formula to homebrew. I like your binary and want it on homebrew, the only issue is that someone else has taken the name "hardlink" so I changed the binary's name to something more Unixy. You can throw away all my changes and just leave some ability for me to compile with a different binary name, I can do the rest. Let me know! Thanks

selkhateeb commented 9 years ago

@jasonsyoung I want to thank you for this great work. I took a quick look at the diff, all looks great. The only thing I noticed is that in the README file, you added "Forked for homebrew" which talks about why you forked it.

If you could change this section to be instructions on how to install it using homebrew. Once the change is made, I wouldn't mind merging it.

Thank you!

jasonsyoung commented 9 years ago

I have updated the README. I’ll issue another pull request. Thanks!!

From: Sam Sent: ‎Thursday‎, ‎October‎ ‎23‎, ‎2014 ‎5‎:‎31‎ ‎AM To: selkhateeb/hardlink Cc: Jason

@jasonsyoung I want to thank you for this great work. I took a quick look at the diff, all looks great. The only thing I noticed is that in the README file, you added "Forked for homebrew" which talks about why you forked it.

If you could change this section to be instructions on how to install it using homebrew. Once the change is made, I wouldn't mind merging it.

Thank you!

— Reply to this email directly or view it on GitHub.

jasonsyoung commented 9 years ago

I have changed it. Any updates?

selkhateeb commented 9 years ago

Thanks.