selkies-project / selkies-gstreamer

Open-Source Low-Latency Accelerated Linux WebRTC HTML5 Remote Desktop Streaming Platform for Self-Hosting, Containers, Kubernetes, or Cloud/HPC
https://selkies-project.github.io/selkies-gstreamer/
Mozilla Public License 2.0
380 stars 48 forks source link

Audio does not play on "START" button press #131

Closed DAB0mB closed 10 months ago

DAB0mB commented 11 months ago

If I press randomly on other elements on the screen before the playback loads, the video and audio would start autoplaying as soon as the connection is ready without any issues. If no mouse event was triggered during playback load, the "START" button will show, but when I press on it, only the video would start playing, not the audio. I believe it's not a WebRTC issue, because when I grab the audio element "audio.audio" and call the audio.play() method, it would actually start playing. Maybe by calling playAudio() on "START" button "click" event, would solve the issue (see code).

ehfd commented 11 months ago

Associated with #109.

ehfd commented 10 months ago

Applied a fix in https://github.com/selkies-project/selkies-gstreamer/commit/6d16d0052a4ec80e136996d7634c68a2cb350a90. Need to test.

ehfd commented 10 months ago

@DAB0mB Please test the fix this works for you as well (latest ghcr.io/selkies-project/selkies-gstreamer/gst-py-example:main-ubuntu20.04 or ghcr.io/selkies-project/selkies-gstreamer/gst-py-example:main-ubuntu22.04).

ehfd commented 10 months ago

I understand that the issue was fixed. Please reopen if it was not.

ehfd commented 9 months ago

109 still has issues.