Explain relevant issues and how this pull request solves them
This pull request fixes the issue #98 by implementing the a scaling technique to change the cursor speeds.
Describe the changes in code and its dependencies and justify that they work as intended after testing
The changes revolve around detecting if client and server are having different resolutions, if so, we'd introduce the cursorScalingFactor which is then be used to scale the relative cursor speeds by multiplying the relative cursor position (x and y values) with the scalingFactor before sending to server. Thus based on the scaling factor the speed could either increase or decrease to provide smooth user experience.
Describe alternatives you've considered
NA
Additional context
The code includes a check if the client resolution is the range of delta 10, this is done due to the reason that sometimes the video and window resolution doesn't match quite exactly.
[x] I confirm that this pull request is relevant to the scope of this project. If you know that upstream projects are the cause of this problem, please file the pull request there.
[x] I confirm that this pull request has been tested thoroughly and to the best of my knowledge that additional unintended problems do not arise.
[x] I confirm that the style of the changed code conforms to the overall style of the project.
[x] I confirm that I have read other open and closed pull requests and that duplicates do not exist.
[x] I confirm that I have justified the need for this pull request and that the changes reflect the fix for the specified problem.
[x] I confirm that no portion of this pull request contains credentials or other private information, and it is my own responsibility to protect my privacy.
Reference the issue numbers and reviewers
98 @ehfd
Explain relevant issues and how this pull request solves them This pull request fixes the issue #98 by implementing the a scaling technique to change the cursor speeds.
Describe the changes in code and its dependencies and justify that they work as intended after testing The changes revolve around detecting if client and server are having different resolutions, if so, we'd introduce the cursorScalingFactor which is then be used to scale the relative cursor speeds by multiplying the relative cursor position (x and y values) with the scalingFactor before sending to server. Thus based on the scaling factor the speed could either increase or decrease to provide smooth user experience.
Describe alternatives you've considered NA
Additional context The code includes a check if the client resolution is the range of delta 10, this is done due to the reason that sometimes the video and window resolution doesn't match quite exactly.