selkies-project / selkies-operator

K8s operator for per-user stateful workloads
https://selkies.io
Apache License 2.0
73 stars 12 forks source link

Upgrade `autoneg-controller` to an upstream release #48

Closed JanCVanB closed 1 year ago

JanCVanB commented 2 years ago

We used (and built) the existing fork/branch to get a bug fix, but Google's upstream repo has since fixed the bug and published releases.

JanCVanB commented 2 years ago

Is setup/scripts/fix_autoneg.sh related to the retry-register-with-backend problem? If so, should we also update/remove it (and its references in cloudbuild.yaml and README.md)?

danisla commented 2 years ago

@JanCVanB can you reconcile the changed in the manifest too? https://github.com/GoogleCloudPlatform/gke-autoneg-controller/blob/master/deploy/autoneg.yaml

JanCVanB commented 2 years ago

@JanCVanB can you reconcile the changed in the manifest too? https://github.com/GoogleCloudPlatform/gke-autoneg-controller/blob/master/deploy/autoneg.yaml

Is https://github.com/selkies-project/selkies/pull/48/commits/bfc2076d4e5be2abdb5907fb463e32869cfaf587 what you had in mind?

danisla commented 2 years ago

@JanCVanB can you reconcile the changed in the manifest too? https://github.com/GoogleCloudPlatform/gke-autoneg-controller/blob/master/deploy/autoneg.yaml

Is bfc2076 what you had in mind?

Not really, need to diff the upstream manifest with the current one.

JanCVanB commented 2 years ago

@JanCVanB can you reconcile the changed in the manifest too? https://github.com/GoogleCloudPlatform/gke-autoneg-controller/blob/master/deploy/autoneg.yaml

Is bfc2076 what you had in mind?

Not really, need to diff the upstream manifest with the current one.

Ah, the entire file, not just the changed subsection - on it

JanCVanB commented 2 years ago

@JanCVanB can you reconcile the changed in the manifest too? https://github.com/GoogleCloudPlatform/gke-autoneg-controller/blob/master/deploy/autoneg.yaml

@danisla how about this: https://github.com/selkies-project/selkies/pull/48/commits/18d013e55b69446171954ae82ac1fb22358c2db7

JanCVanB commented 2 years ago

@danisla Thanks for those (now-overwritten, whoops) comments, they made perfect sense. How does https://github.com/selkies-project/selkies/pull/48/commits/d7a520d1796e014d4a2402f9dbeb605fc1f460df look?

JanCVanB commented 1 year ago

Closing for staleness