selkies-project / selkies-vdi

WebRTC & Xpra desktops on Selkies
https://selkies.io
Apache License 2.0
66 stars 17 forks source link

Introduce enableSudo param to control whether the desktop container can gain sudo privileges. #47

Open reisbel opened 2 years ago

reisbel commented 2 years ago

Introduce a brokerappconfig param to control whether the desktop container can gain sudo privileges.

Description: control whether the desktop container can gain sudo privileges. Path: spec.appParams.enableSudo Default value: true Usage

#spec.appParams.enableSudo
spec:
 #appParams section
 appParams:
   - name: enableSudo
     default: "false"
danisla commented 2 years ago

This might break the docker compatibility feature, the docker.sock is created in the xpra entrypoint https://github.com/selkies-project/selkies-vdi/blob/master/manifests/brokerapp-base/webrtc-bundle-manifests/jsonpatch-deploy-xpra.yaml.tmpl#L51