20110629: POSIX shell construct problems (use of -a and -o logical operators)

GoogleCodeExporter commented 8 years ago

The following warnings are reported by checkbashisms[*] program: 

possible bashism in debian/winetricks/usr/bin/winetricks line 1082 (test -a/-o):
            if test $minsize -gt 1 -a $filesize -ne $minsize
possible bashism in debian/winetricks/usr/bin/winetricks line 1087 (test -a/-o):
            if test "$check_sha1" != "" -a "$sha1sum"x != ""x

For more information about -a and -o see:

  Shell - Bash - FAQ 006 BashPitfalls -a/-o not portable (Greg's Wiki)
  http://www.delicious.com/jariaalto/bash+faq

[*] http://packages.debian.org/devscripts

Original issue reported on code.google.com by jari.aalto.fi@gmail.com on 19 Sep 2011 at 10:27

GoogleCodeExporter commented 8 years ago

Thought I fixed that.
We'll just keep driving a stake through that bug's heart every time it comes 
back...

Original comment by daniel.r...@gmail.com on 19 Sep 2011 at 10:30

GoogleCodeExporter commented 8 years ago

Theis appears to be no longer problem in r918, please close this issue.

Original comment by jari.aalto.fi@gmail.com on 1 Nov 2012 at 6:20

GoogleCodeExporter commented 8 years ago

Checkbashisms no longer complains as of r960 / checkbashisms 2.13.2

Original comment by austinenglish@gmail.com on 15 Jun 2013 at 6:54

Changed state: Fixed

sellingrich / winetricks

20110629: POSIX shell construct problems (use of -a and -o logical operators) #130