search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.16k stars 202 forks source link

Magit highlighting broken #126

Closed csdrane closed 9 years ago

csdrane commented 9 years ago

I think this [1] commit tried to fix the issue but highlighting in magit is still broken for me. The face of the hightlighted text is the same color as the background.

 [1] https://github.com/sellout/emacs-color-theme-solarized/pull/124
calve commented 9 years ago

I assume you are talking of this commit Are you using the next branch of magit ?

csdrane commented 9 years ago

I'm not clear on how to check my magit version--I believe I'm on the master trunk. I installed via ELPA. As I read the commit now, the patch was designed to fix display issues with magit-next. My display issues though are with master AFAICT.

On Tue, Oct 28, 2014 at 10:47 AM, calve notifications@github.com wrote:

I assume you are talking of this commit https://github.com/calve/emacs-color-theme-solarized/commit/3e0edb903bd2e94f59bea9f4e3eb53405c4e3b2e Are you using the next branch of magit ?

— Reply to this email directly or view it on GitHub https://github.com/sellout/emacs-color-theme-solarized/issues/126#issuecomment-60766970 .

calve commented 9 years ago

As far as I know, ELPA do not have the ability to checkout a revision, so you are probably on master since the next branch is yet to be merged. Maybe try adding (setq solarized-diff-mode "high") to your emacs configuration helps ?

You might try to explore from which faces your magit-diff faces inherits by placing your point where the colors go wrong and M-x describe-face

csdrane commented 9 years ago

It looks like my problem is due to magit-item-highlight, which inherits from secondary-selection, which is defined as black on black for some reason.

Below is an example of the issue I'm experiencing.

screen shot 2014-10-28 at 12 23 46 pm

screen shot 2014-10-28 at 12 22 22 pm

sellout commented 9 years ago

I don’t seem to have a magit-item-highlight face on my system, and secondary-selection is reasonably defined (should be base0 on base02).

Could you update to the latest from master and see if you’re still seeing this issue? Thanks.

sellout commented 9 years ago

Sorry – I do have magit-item-highlight and it’s defined as you said (magit just hadn’t been loaded in my session). However, it looks fine to me as does the definition of secondary-selection, so I’m still no help.

csdrane commented 9 years ago

I switched to the Cocoa emacs and everything is gravy now.

On Wed, Jan 7, 2015 at 12:42 AM, Greg Pfeil notifications@github.com wrote:

Sorry – I do have magit-item-highlight and it’s defined as you said (magit just hadn’t been loaded in my session). However, it looks fine to me as does the definition of secondary-selection, so I’m still no help.

— Reply to this email directly or view it on GitHub https://github.com/sellout/emacs-color-theme-solarized/issues/126#issuecomment-68981399 .

sellout commented 9 years ago

Great! Thanks for responding.