search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

Fixed CL functions #137

Closed hostmaster closed 9 years ago

hostmaster commented 9 years ago

See https://github.com/sellout/emacs-color-theme-solarized/issues/136

I am not sure this is suitable for all version of Emacs but it works for me.

sellout commented 9 years ago

Could you try a version that looks like:

(unless (require 'cl-lib nil t)
  (require 'cl)
  (defalias 'cl-case 'case)
  (defalias 'cl-copy-list 'copy-list))

That should let us use the proper prefixed names even on older versions that don’t have cl-lib.

sellout commented 9 years ago

Fixes #136 (just to make sure I don’t forget to close the ticket).

hostmaster commented 9 years ago

@sellout thank you. It works for me

should it be inside (eval-when-compile ) ?

sellout commented 9 years ago

Yep – while cl-lib is (I think) safe without it, cl pollutes the namespace with unqualified symbols, so you don’t want to risk loading it at runtime.

hostmaster commented 9 years ago

Ok. It works for me

sellout commented 9 years ago

Great – can you push it to your branch so I can merge?

hostmaster commented 9 years ago

hold on plz

hostmaster commented 9 years ago

my bad, I've made a mistake and broke identation. fixed now

hostmaster commented 9 years ago

my bad again. sorry for that. build is green now