search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

Instructions for Emacs 24 don't work #16

Closed davidsantiago closed 13 years ago

davidsantiago commented 13 years ago

When I follow the instructions for Emacs 24 in the README, it doesn't appear to work for me. Enable-theme does not find the themes. I can only get the themes to load by adding the solarized directory to the loadpath, and then either (require 'solarized-dark-theme) or (require 'solarized-light-theme). Even after I require the one I want, enable-theme still won't find it. Nor will load-theme.

Is there perhaps a step missing?

David

sellout commented 13 years ago

Did you pull my update from this morning? From when I pulled in your fix for issue #12. I think that fixed this problem. It wasn't finding the themes because there was no deftheme form. If you have that and it's still not working, I'll try to dig deeper.

davidsantiago commented 13 years ago

Yeah, I waited to file this until I saw your fix appear and put it into place.

I can use load-theme to get built-in themes, like wheatgrass, tango-dark, and wombat. But it appears as if Emacs doesn't know to go scanning files for a deftheme unless you've told it to load that file first.

Anyhow, I'm not saying anything's wrong necessarily, just that the instructions don't seem to work for me. I have to manually read the file with require, and only when the file is read in that way will the theme be set. As I said, though, I'm not an Emacs Lisp guy and have very little understanding of how this stuff is supposed to work.

On Fri, May 6, 2011 at 3:21 PM, sellout < reply@reply.github.com>wrote:

Did you pull my update from this morning? From when I pulled in your fix for issue #12. I think that fixed this problem. It wasn't finding the themes because there was no deftheme form. If you have that and it's still not working, I'll try to dig deeper.

Reply to this email directly or view it on GitHub:

https://github.com/sellout/emacs-color-theme-solarized/issues/16#comment_1113422

mathieulegrand commented 13 years ago

I cloned the repository today, and indeed the instructions do not work. I added (add-to-list 'load-path "~/.emacs.d/emacs-color-theme-solarized") to my init.el to point to the cloned git directory, but enable-theme does not see solarized. I tried to load-library solarized and it helped, but I am not sure whether this is an acceptable workaround or not. In any case, the instructions need an update.

iand675 commented 13 years ago

This is what I have in my init.el, and it doesn't work either. I just get told that solarized-dark is an undefined theme, even though it shows up in completion mode.

(add-to-list 'load-path (concat dotfiles-dir "vendor/emacs-color-theme-solarized"))
(require 'solarized-definitions)
(add-to-list 'custom-theme-load-path (concat dotfiles-dir "vendor/emacs-color-theme-solarized"))
(load-theme 'solarized-dark)
davidsantiago commented 13 years ago

@ahyatt has pointed out that changing make-symbol back to intern in solarized-definitions.el, L289 will fix this, and I have tried it and confirmed.

sellout commented 13 years ago

Sorry for the long delay, everyone. Hopefully this is fixed now.

semperos commented 13 years ago

I don't mean to open old wounds, but it's still not working for me.

I've added the directory to my load-path, but the only option enable-theme gives me is user. Any thoughts?

davidthewatson commented 12 years ago

I have the same issue as semperos. Could you give the specific load-path line that works in emacs 24?

Thanks.

ahyatt commented 12 years ago

I use this to load it: (add-to-list 'load-path "~/.emacs.d/src/emacs-color-theme-solarized/") (add-to-list 'custom-theme-load-path "~/.emacs.d/src/emacs-color-theme-solarized")

But I use my own emacs-solarized, with extra fixes: https://github.com/ahyatt/emacs-color-theme-solarized

On Tue, Sep 20, 2011 at 12:17 PM, David Watson reply@reply.github.com wrote:

I have the same issue as semperos. Could you give the specific load-path line that works in emacs 24?

Thanks.

Reply to this email directly or view it on GitHub: https://github.com/sellout/emacs-color-theme-solarized/issues/16#issuecomment-2146770

davidthewatson commented 12 years ago

Thanks, ahyatt. That works.

dignifiedquire commented 12 years ago

@ahyatt Thanks. Your info saved my day.

pchalasani commented 12 years ago

I'll add my vote to this -- thank you! it was so hard to get the emacs-24 to start with "solarized dark". This solved it for me!

KarthikNayak commented 10 years ago

thanks ahyatt that works :dart: