search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.16k stars 202 forks source link

Emacs' version of solarized uses wrong colors for highlighting elements. #169

Closed axg-ux closed 8 years ago

axg-ux commented 8 years ago

Compared with the stock vim version it is easy to see how most elements of syntax use "wrong colors" at least not the default spec. Why is that the behavior of the official emacs solarized theme?

In the screenshot attached, on the left is seen emacs using rather strangle highlighting colors for some config in haskell, compared to the right side, where a vim version of the same document is launched. Is there a reason for such behavior? Can it be fixed or reversed?

2015-08-28-232155_1917x1062_scrot

sellout commented 8 years ago

Here’s the high-level explanation:

https://github.com/sellout/emacs-color-theme-solarized/wiki/Why-doesn't-it-look-like-the-VIM-version%3F

I’m happy to accept PRs (or issues) for specific things that are wrong with the theme, but I expect many of these differences are due to the mode or face definitions.

axg-ux commented 8 years ago

I see so it is the specific major modes that decide what colors to use for highlighting specific syntax elements (or faces as you seem to refer to them in emacs). Therefore in order to change the way some piece of code in a specific language looks, I could go into the major mode's syntax highlighting specification and play with it in there. Am I seeing this through right?