Add bg versions for `term-color-N` faces

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme

http://ethanschoonover.com/solarized

MIT License

1.16k stars 202 forks source link

Add bg versions for `term-color-N` faces #180

Closed bradwright closed 8 years ago

bradwright commented 8 years ago

Without these, reversed faces in ansi-term (eg black foreground on yellow background) or similar don't display properly - the background colour just inherits from default.

Before (with selected text to highlight the issue):

After:

sellout commented 8 years ago

Hunh, interesting. Thanks for submitting this. Does this seem like a bug in ansi-term? It feels that way to me.

bradwright commented 8 years ago

It's been in the other solarized since 2014: https://github.com/bbatsov/solarized-emacs/commit/5a5d77ff3b9e5615105a4eb6a6ff750b967d2702 although I'm not sure why I only just noticed it.

bradwright commented 8 years ago

http://stackoverflow.com/questions/15661372/adjusting-term-faces-in-the-new-emacs-24-3#comment22551546_15662216 also has some history. Seems like fairly recent code (by Emacs standards). Also seems to be reflected in core face definitions.

bradwright commented 8 years ago

The default Emacs theme has:

M-x describe-face term-color-black
   Foreground: black
   ...
   Background: black

So it appears even Emacs core themes behave like this.

bradwright commented 8 years ago

Bump?