search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.16k stars 202 forks source link

Fix whitespace-newline face #181

Closed geraldus closed 8 years ago

geraldus commented 8 years ago

This makes newline symbols to be highlighted according to screenshots (example1, example2). Visual diff Before

2016-02-19 16 54 13 2016-02-19 16 55 17

Note, with dark background newline chars are very distractive. After:

2016-02-19 16 48 46 2016-02-19 16 49 10

Note, if you have hl-line-mode enabled it plays nice with new settings: newline char have same foreground color as current line background color and disappears reducing distraction.

Small screenshots looks quite uninformative, here are few bigger ones:

2016-02-19 17 26 42 2016-02-19 17 26 28

One weird thing I've discovered, that current version of solarized theme have different color for newlines, but it is also very distractive (especially with light background), observe:

2016-02-19 17 28 00 2016-02-19 17 28 13

What do you think?

sellout commented 8 years ago

I’m fine with this, but what do you think about using (:inherit shadow) instead of (,@fg-base02)? It’s in between the old and new values, and is the standard for things that should be more subtle.

I understand if that’s not quite subtle enough in this case, though.

geraldus commented 8 years ago

@sellout ok, looks comfortable: more visible and non distractive. One caveat, I added slant attribute, this prevents newline char to be italicized in comments.

geraldus commented 8 years ago

Something wrong with tests (though I think you've already spotted this).

sellout commented 8 years ago

Yeah, looks like it’s recently started failing to install Emacs. On my list to fix ;)

But your changes look good.