Add web-mode customizations

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme

http://ethanschoonover.com/solarized

MIT License

1.16k stars 202 forks source link

Add web-mode customizations #185

Open geraldus opened 8 years ago

geraldus commented 8 years ago

Override following faces:

web-mode-current-column-highlight-face
web-mode-current-element-highlight-face

Before:

After:

geraldus commented 8 years ago

Wait, don't merge this. I've found I could add more faces! :D

geraldus commented 8 years ago

Ok, now it looks better (: 2016-02-21 1 01 22 2016-02-21 1 01 45

Javascript preview: 2016-02-21 1 56 48 2016-02-21 1 57 42

geraldus commented 8 years ago

@sellout oh, I guess it is better to inherit properties from Javascript and HTML faces, let me check how HTML and Javascript in native modes and how them appear in Vim. I'll ping you a bit later.

geraldus commented 8 years ago

Hmm… @sellout default HTML and Javascript highlighting do not shine both in Emacs and Vim too. First of all coloring is different in Emacs and Vim. Second, Vim colouring is quite odd and very different to what I see on screenshot :D I have no idea what is the best way to go from here. I could provide screenshots for both Emacs and Vim colors.

Also I have few off-topic questions, is it OK to ask them in separate issues?