Color differences and problems with emacs.

[milkypostman]

From what I can tell it looks like you have a "Generic RGB" and a "sRGB" in the color-theme definitions where the sRGB are taken directly from the solarized definition and the Gen RGB are you trying to "match" the intended colors. At least for Emacs.app on Mac, the problem lies in Emacs itself,

https://github.com/mxcl/homebrew/pull/5194

There has been a lot of discussion and it seems like it's an upstream issue that needs to be fixed but on my version, the sRGB is actually what I think I want (because I have a version of emacs compiled with the color fix). Is there a way to tell solarized to not pick the generic RGB colors? Else I'll just go modify the definitions file myself.

[gglanzani]

I got the same problem, and I just corrected the colors by hand, making Generic RGB equals to sRGB.

[rma]

I also have this issue on Debian Testing with emacs 23.3.1, so I made the following change:

--- a/solarized-definitions.el +++ b/solarized-definitions.el @@ -65,7 +65,7 @@ will use the 256 degraded color mode." (let ((index (if window-system (if solarized-degrade 3

• 2)
• 1) (if (= solarized-termcolors 256) 3 4))))

Perhaps there could be an option to use the "Generic RGB" or "sRGB" colours?

[hdhoang]

my fork's branch srgb-option implements such an option. I would like help with the description, and maybe defaulting to nil only on Mac emacs.

https://github.com/hdhoang/emacs-color-theme-solarized/tree/srgb-option

[rma]

Nice work! To default to nil only on Mac systems, something like the following should work:

(defcustom solarized-srgb (if (eq system-type 'darwin) nil t)
  "Use Generic RGB ..."
  ...)

As far as the description goes, I don't think I know enough about color-spaces to offer much advice. Perhaps something like "Set to 't to use the sRGB colors; set to 'nil to use generic RGB colors which are device-specific, but may produce better results than the sRGB definitions. This defaults to 'nil on Mac systems and 't on all other platforms."

[lukehoersten]

I have the same color difference problem on Linux as well.

[sellout]

Since the patch has been applied to both Emacs 23 and 24 about 8 months ago, should I just get rid of the Gen RGB stuff and use sRGB for everything now?

[sellout]

Oh, I'm sorry – that patch was for homebrew only. I'll go ahead with adding the variable and defaulting to nil on Macs.

[sellout]

I've added the option, but I did the inverse of @hdhoang, so the variable is called solarized-broken-srgb and defaults to t on Macs only.

[lukehoersten]

This looks sooo much better on Linux. Thanks so much for adding this fix!