search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.16k stars 202 forks source link

Refactor solarized-definitions.el for customization #191

Open sambrightman opened 7 years ago

sambrightman commented 7 years ago

This makes it easier to customize and test proposed changes to solarized-color-definitions. solarized-with-color-variables allows definition of faces within the same context that is used for solarized-color-definitions. Hence, the changes you test yourself can be directly copied into the official code-base for a PR. They are also easy to maintain in your own Emacs init scripts before merge or if tweaking the official settings. The approach is copied from @bbatsov's themes.

For example, setting up additions/customizations goes like this:

(defvar my/solarized-extra-definitions
  (solarized-with-color-variables
    `(;; cperl
      (cperl-array-face (,@fg-blue))
      (cperl-hash-face (,@fg-blue))
      (cperl-nonoverridable-face (,@fg-magenta)))))
(solarized-apply-definitions my/solarized-extra-definitions 'solarized)
sellout commented 1 year ago

I really like this and would love to integrate it. However, the code base has moved around a bit, and it would need to be updated to be merged. I’m happy to take it across the finish line, but it’s your work, so I want to leave it to you, if you’re still interested after all this time. Let me know. Thanks!

sambrightman commented 1 year ago

I still prefer this package to the more popular ones, to the extent I'm copying it around all my installations after it was removed from MELPA. Will it be making a comeback? If so, I'd love to get this integrated (and you're welcome to do it yourself if I don't find time).

sellout commented 1 year ago

That's nice to hear. I have a bunch of updates that have accumulated and should have them all up shortly, then yes, it should be back on MELPA soon. It will also have a Nix flake, if that's your style.

I might be able to get this integrated tonight.