search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

Changing flymake-errline in definitions doesn't override default setting #28

Closed ghost closed 12 years ago

ghost commented 13 years ago

The default font for flymake-errline is

(flymake-errline ((t (:background ,orange)))).

However, I prefer flymake to underline code instead of changing the background (to avoid this kind of problem). So I changed the above definition to

(flymake-errline ((t (:underline ,orange))))

but the result is that after loading solarized via load-theme in Emacs 24, flymake errors have an orange background and underline.

It seems that stuff from the definitions file is added to the default font specification instead of overriding it.

When loading the theme the Emacs 23 way via color-theme-solarized-light, the original font is overridden and flymake errors are only underlined.

sellout commented 12 years ago

Yes, I don't think this is anything that can be handled by the theme. Also, to some extent, this is what we want. We don't want to trample the font height, family, etc. that is either used by default or set by the user. We just want to replace the colors for the most part.

I changed the flymake colors, so maybe they will look better to you now. Let me know what you think.