search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

Color theme doesn't apply to eshell #29

Closed lukehoersten closed 12 years ago

lukehoersten commented 12 years ago

The eshell buffer colors (aside from the background color) don't apply from the Solarized theme.

sellout commented 12 years ago

The only eshell-specific face I could find was eshell-prompt. I added a definition for it. Please let me know whether or not this fixes the issue for you. If it doesn't, it would be helpful if you could include a screenshot with the problem.

Thanks.

lukehoersten commented 12 years ago

I'll test it out. Thanks a lot.

lukehoersten commented 12 years ago

The prompt looks a lot better but if you just start eshell, type ls and you should see a whole bunch of non-solarized colors. Here's how to turn colors on in Emacs Eshell:

(add-hook
 'eshell-mode-hook
 (lambda ()
   (setenv "TERM" "emacs") ; enable colors
  ))

Let me know if this doesn't produce the problem for you.

sellout commented 12 years ago

Alright, got 'em all. Thanks for pointing that out – didn't realize you could have color ls in eshell.

lukehoersten commented 12 years ago

Awesome - thanks a lot.

lukehoersten commented 12 years ago

Where did you find the variables you could set for eshell colors? I'd like to add things like diff as I find them. I can submit patches to you then.

sellout commented 12 years ago

I'm just starting to write up a section in the readme on how to include better info on bug reports. The relevant bit here is that you can put the cursor over whatever is mis-colored and then do M-x describe-face and that'll give you the name of the face at point.

So once I enabled color ls, I could see what was wrong and describe-face on one of the ls entries. You can also do M-x customize-apropos-faces and type something like eshell and it'll find all the faces that match (which is what I should have done in the first place, rather than poking around through customize trying to find other faces in the maze of eshell groups).

xnox commented 11 years ago

For gnome-terminal there is a soloarised profile which sets the basic 16 colours, text color, bold and highlight. I am trying to find a way to modify those in eshell, then most terminal commands will be nice.