Make diff-mode not ugly

[LukeShu]

Make diff-mode not look like my cat barfed on the screen after eating a mouse.

Basically 4 things happened:

• diff-{remove,add,change} no longer :inverse-video; it was painful to look at.
• diff-add is now cyan, not green. The green is a sort of ugly brown-green. A diff with too many added lines looked like barf.
• base{0,1} are for foreground, and base{2,3} are for background. I'm sure there are situations where it's OK to break this, but diff-{header,file-header,refine-change} are not the place.
• define the face shadow; it's inherited by diff-context.

Happy hacking!

[sellout]

Thanks. The old diff stuff was probably something that would have made @altercation put his eyes out as well. I made changes to match the VIM diff mode highlighting better. They're not too different from yours, so maybe you'll like them.

There is also a new variable solarized-diff-mode to parallel the one in the VIM sources. high will do inverse video, normal bolds, and low underlines.

And there are other changes to improve the color display on various platforms (including a new solarized-broken-srgb variable), so perhaps you won't find the green so distasteful anymore.