search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

slow scrolling #43

Closed osa1 closed 12 years ago

osa1 commented 12 years ago

I wasn't updating the repo for a long time, and after updating it, scrolling in text got slowed down making my Emacs unusable. Changing to other colorschemes makes my emacs scroll normal again. I inspected commits a little bit and found the commit causes this:

commit c003d9a45cef116da717a828a46d5ebc25729b6c
Author: Greg Pfeil <greg@technomadic.org>
Date:   Thu Feb 16 17:54:40 2012 -0700

    Bring more colors in line with VIM faces.

Before this commit, scrolling is fine.

I'm not sure whether it's about Emacs or solarized colorscheme but I wanted to show. My setup: GNU Emacs 23.3.1 (x86_64-suse-linux-gnu, GTK+ Version 2.24.7)

sellout commented 12 years ago

Thanks for narrowing it down to the commit. Are you using something from http://www.emacswiki.org/emacs/SmoothScrolling to do more incremental scrolling than the usual half-page jump? Also, I assume you're using the color-theme rather than the Emacs 24 theme (since you are on Emacs 23).

I tried switching to the color-theme and (setq scroll-step 1), but my Emacs 24 still behaves fine. Any idea which of the relevant faces might be in use when you're scrolling? Does switching to fundamental-mode fix scrolling for that buffer?

Also, since I don't have Emacs 23, GTK, or Linux, there might be something involved that I can't replicate. I'm happy to bounce this back and forth a few times, but if you can maybe try reverting that commit one line at a time and seeing which individual face is causing it, that could be a big help.

Sorry for the frustration – maybe Emacs 24 will be out soon ;)

osa1 commented 12 years ago

Yeah I'm using smooth scrolling settings but even after disabling it, scrolling is still slow. Also, strangely enough, switching to fundamental-mode didn't change scroll speed.

After my first message I've played with some other colorschemes and realized that I'm having the same problem with some other colorschemes too(for example, gentooish).

btw, I've just inspected the commit line by line and found the code caused this:

(mode-line  ; StatusLine
  ((t (,@fg-base1 ,@bg-base02 ,@fmt-revbb :box nil))))

And this is the part related with the chage before the commit:

(mode-line
  ((t (,@fg-base1 ,@bg-base02 :box (:line-width 1 :color ,base1)))))

I have no idea how can this code effect scroll speed, since what it's doing is just changing status bar's colors :) .

Anyway, I think we just found a bug in color-theme or I'm missing some points :) . Thanks for this great work.