search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

The current master is broken on emacs 23. #49

Closed Omnifarious closed 12 years ago

Omnifarious commented 12 years ago

This patch fixes the brokenness. It's a bit of a hack. It basically checks to see if the custom-theme-load-path symbol exists before using it.

sellout commented 12 years ago

The changes to solarized-dark-theme.el and solarized-light-theme.el are unnecessary, since those files should only be loaded on Emacs 24. I'll make the change to solarized-definitions.el in the style of pull request #48.

Thanks for bringing attention to the fact that I haven't fixed this yet.

Omnifarious commented 12 years ago

On Fri, Mar 16, 2012 at 02:50:10PM -0700, Greg Pfeil wrote:

The changes to solarized-dark-theme.el and solarized-light-theme.el are unnecessary, since those files should only be loaded on Emacs 24. I'll make the change to solarized-definitions.el in the style of pull request #48.

Thanks for bringing attention to the fact that I haven't fixed this yet.

I have the line:

(enable-theme 'solarized-dark)

in my .emacs.d/init.el file, and that line works with those changes to solarized-dark.theme.el and doesn't without them.

"They who can give up essential liberty to obtain a little temporary safety, deserve neither liberty nor safety." -- Benjanmin Franklin -- Eric Hopper (http://www.omnifarious.org/~hopper) --

Omnifarious commented 12 years ago

Nevermind. I was using the wrong method of getting the theme loaded. Now to figure out how to override its idea of what my cursor color should be. :-)