search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

Improve flymake-errline face for solarized-dark #52

Closed bradwright closed 12 years ago

bradwright commented 12 years ago

At the moment flymake-errline highlights things with an almost-white background, which makes the text less readable. The colour in question is base3, which is:

"#fdf6e3"

I've got this in my custom.el:

'(flymake-errline ((t (:background nil :foreground "#dc322f"))))

which just uses the error face as the foreground colour.

Something like this for flymake-errline would be nice:

https://github.com/sellout/emacs-color-theme-solarized/commit/e39988b7433798b35a84754694bee840937f86fa

I can send a pull request if you in theory like this idea.

sellout commented 12 years ago

How's this look? I generally try to map faces to something similar in the VIM definitions (since Ethan is a much better designer than me).

bradwright commented 12 years ago

For some reason it has this under customize:

Background: Firebrick4

which makes it red on red.

Emacs Flymake error

bradwright commented 12 years ago

So turns out Firebrick4 is the default background colour for flymake-errline, so we just need to unset :background, or set it to the same background as the rest of the text (@bg-base03 I believe).

sellout commented 12 years ago

Thanks, @bradleywright. I don't have Flymake, so when I checked it under my own customize, I didn't see an issue. I overrode the background for both error and warning. I'm going to close this, but feel free to reopen if it's still no good.