search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

colors except background are not set in recent emacs-snapshot #56

Closed vspinu closed 12 years ago

vspinu commented 12 years ago

Hi,

I've noticed a weird issue with the recent emacs-snapshot.

After 

(color-theme-solarized 'dark)

only background is changed. All other colors are not affected. Instead 

(create-solarized-theme dark)

works fine.

Everything works fine with emacs 23.4 and 3 weeks old emacs 24. It's only the most recent snapshot of emacs GNU Emacs 24.1.50.1 (i686-pc-linux-gnu, GTK+ Version 3.2.0) of 2012-04-23 on aluminium, modified by Debian which gives these trouble. Can anyone reproduce?

sellout commented 12 years ago

There was a commit with some shoddy changes the other day, but I think I fixed them up yesterday in f41e9e4db, so make sure you're completely up-to-date. My build of 24.1.50 seems to behave properly with the latest changes (both in console and GUI, both color-theme and Emacs 24 theme).

Also, (create-solarized-theme dark) shouldn't really be called directly. You probably want (load-theme 'solarized-dark t) to load the Emacs 24 theme correctly.

vspinu commented 12 years ago

Greg Pfeil reply@reply.github.com on Sun, 29 Apr 2012 18:23:54 -0700 wrote:

There was a commit with some shoddy changes the other day, but I think I fixed them up yesterday in f41e9e4db, so make sure you're completely up-to-date. My build of 24.1.50 seems to behave properly with the latest changes (both in console and GUI, both color-theme and Emacs 24 theme).

With the most recent commit, the problem persists.

Also, (create-solarized-theme dark) shouldn't really be called directly. You probably want (load-theme 'solarized-dark t) to load the Emacs 24 theme correctly.

I had in my .emacs

(require 'color-theme-solarized) (color-theme-solarized-dark)

which worked in emacs 23, but not in 24 anymore.

I was not aware that emacs 24 need a different setup. Now I have

(if (> emacs-major-version 23) (load-theme 'solarized-dark t) (require 'color-theme-solarized) (color-theme-solarized-dark) )

And it works both in 23 and 24. So I consider it solved. Thanks.

sellout commented 12 years ago

I use a similar emacs-major-version check, but mostly to test things. Ideally, (color-theme-solarized-dark) should work anywhere (including Emacs 24) that has color-theme installed, while (load-theme 'solarized-dark t) will only work on Emacs 24.

Hopefully, this was an odd interaction between Debian's emacs, the version of color-theme, or whatever. I'll close it for now and cross my fingers that it doesn't bit anyone else.