search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

why doc face is red now? #57

Closed vspinu closed 12 years ago

vspinu commented 12 years ago

I find it extremely disturbing to see red font-loc-doc-face. This is a pretty recent change as far as I can tell, sorry if I am confused.

Previously it was the same color as string face. Now it jumps out of the screen. I think that docs, like comments, should stay in background and not interfere with the coding experience. Now I am pretty much forced to read the docs.

Could this be reverted please?

sellout commented 12 years ago

You're right – I think I was confused by some idiosyncrasies in the Solarized VIM highlighting for JavaDoc, which highlights the title section as Special (red). I have some mixed feelings on this since (unlike comments) docs are part of the API, and so they should be paid more attention in order to keep them in sync. However, red is pretty extreme and most of the VIM modes highlight docstrings the same as strings or comments, so I've brought the Emacs mode back in line with that.

vspinu commented 12 years ago

Thanks Greg. It might be that it's just a habit speaking. May be after some days of use it would not have stricken me anymore. On the other hand some packages document a lot of e-lisp and that means full pages of red, pretty extreme :).