search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

the sRGB fix is not necessary for Mac build 3.2+, also post Mountain Lion? (need confirmation) #66

Closed lewang closed 12 years ago

lewang commented 12 years ago

remove sRGB color fix for mac build

sellout commented 12 years ago

What is “Mac build 3.2+”? It seems as though you’re making sure it doesn’t use this workaround for GTK, is that right?

I think that seems reasonable. I don't use Emacs under X11, so I'm not quite sure how it works there, but if it works for you, I'm happy to take the patch.

lewang commented 12 years ago

I mean Yamamoto's parallely maintained Mac port:

http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00803.html

It's more native feeling than the default NS port. This message quotes changes regarding sRGB.

The default NS build was crashing all the time for me.

I should also note that the sRGB fix is not necessary post Mountain Lion. But I couldn't figure out a way to version check the OS.

sellout commented 12 years ago

Ah, Mac port of Emacs, I see. Well, if the workaround is not necessary at all on the current version of OS X, then I am happy to make the default nil always, and let people who have an out-of-date system manually set it to t.

Actually, since the workaround requires maintaining a separate set of colors, etc., I’m inclined to deprecate it.

I’ll test on Mountain Lion before going ahead with that.

sellout commented 12 years ago

Hrmm, using Mountain Lion (10.8.1) and Emacs HEAD as of this morning, I still need to use the sRGB fix. But your current fix, to only use the workaround on the built-in NS support, seems good, so I'm merging it.

lewang commented 12 years ago

Hi @sellout, sorry about the confusion with ML. I have also confirmed that the fix is still NECESSARY with ML on ns build.

Thanks for the quick response!