search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

@fmt-* in face definition makes faces unmerge-able #67

Closed lewang closed 9 years ago

lewang commented 12 years ago

There are a lot situations where multiple faces are applied to text. For example font-lock-keywords takes a "prepend" and "append" option to manage the order of faces.

However faces which have "@fmt-*" in their definition don't work well with other faces. For example @fmt-bold makes it impossible for another face to specify underline because it wipes it out.

I'm checking the default themes that ship with Emacs24 and they don't do this. Why was this design choice made?

sellout commented 9 years ago

I agree this isn’t ideal. This is how the Vim theme works and in some cases it’s intended. I haven’t yet managed to untangle the cases where you want to stomp on some face properties and the times when you want them to merge.

sellout commented 9 years ago

Ok, I’ve made it so the faces merge better.