search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.16k stars 201 forks source link

emacs24 themes #7

Closed gwenhael-le-moine closed 13 years ago

gwenhael-le-moine commented 13 years ago

Hi,

here's the emacs24 versions. I integrated the additional faces you have with just one or 2 small change. I haven't implemented any of the advanced techniques you have (yet?)

I'm ambivalent about the naming of the repository, I would rename it to emacs-solarized with 2 sub-dirs color-theme/ and emacs24/ but that's your call.

sellout commented 13 years ago

This is great, and I'm in the process of merging it. I have a few questions, though:

  1. Is there something in particular than requires that it's not byte-compiled? I don't see anything, and I'd like to remove that unless there's a reason.
  2. When I load them on OS X, using Cocoa, most faces work, but the default face seems to be black on white (the uncustomized value for Cocoa Emacs). Any idea why this might be happening?

I agree about the repository name, but I'll have to coördinate that change with altercation.