Closed bradwright closed 11 years ago
Brad, I tried your commit and it didn't work for me. Emacs complains about the unspecified
face in ansi-term-color-vector
Turns out you don't have to set ansi-term-color-vector
, you can set term-color-*
faces, which follows with the rest of solarized-definitions.el much better. I made the fix in my pull request https://github.com/sellout/emacs-color-theme-solarized/pull/78. It also includes solarized colors for shell-mode.
@leea it worked fine for me, so I don't know what happened there. I'll give your branch a spin and if it works for me I'll close this.
It doesn't work for me on ansi-term
.
Ahh. The problem seems to be that I'm using an snapshot build of emacs 24.3. The way colors are handled in term.el has changed.
I will add a comment to my pull request.
On Tue, Jan 15, 2013 at 10:59 AM, Bradley Wright notifications@github.comwrote:
It doesn't work for me on ansi-term.
— Reply to this email directly or view it on GitHubhttps://github.com/sellout/emacs-color-theme-solarized/pull/77#issuecomment-12273957.
allen
Closing in favour of #78 (since that works)
When an
ansi-term
buffer is launched, it gets the standard ANSI colours.This can be overridden by explicitly setting
ansi-term-color-vector
whenterm
is loaded. This replaces the standard 8 ANSI colours with the colours from the vector passed in.I have two concerns with this commit:
flet/let
construct. This way the vector could be generated outside the main construct;ansi-term-color-vector
is the best thing to do, but it's what other themes do.