Hides parentheses - Githubissues

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme

http://ethanschoonover.com/solarized

MIT License

1.15k stars 201 forks source link

Hides parentheses #81

Closed honza closed 11 years ago

honza commented 11 years ago

Terminal emacs. iTerm2 with the solarized theme activated. Emacs >=24.

sellout commented 11 years ago

Check out https://github.com/sellout/emacs-color-theme-solarized#bug-reporting – specifically, list the faces that are actually being applied to the invisible parentheses. Also, the mode names (or image of the modeline) would be helpful, too.

Thanks.

honza commented 11 years ago

Welp, sorry about that!

M-x version - GNU Emacs 24.2.1 (x86_64-apple-darwin11.4.0) of 2012-09-27 on macbook
No color-theme
describe-face - not sure what that means

In Vim:

vim

-UU-:----F1  main.clj       All (5,0)     <N>   (Clojure Paredit Undo-Tree Fill) --------

sellout commented 11 years ago

Try putting your cursor over one of the invisible parens (it’s ok if that makes it visible) and typing M-x (face-at-point) – then the minibuffer should show any faces that are in effect there – that’ll help me narrow down the problem space.

I updated the bug reporting section with some other things that would be helpful:

run M-: (display-color-cells) and show me the output, and
try running Emacs in GUI mode if possible, and see if the same problem occurs.

I’ve also created #82 to remind me to make a function that does all this work in one shot to facilitate future bug reporting.

honza commented 11 years ago

(face-at-point) doesn't seem to be defined.

sellout commented 11 years ago

Whoops, typo – should have been M-: (face-at-point).

honza commented 11 years ago

The output is hl-line. Hope this helps. Thanks!

sellout commented 11 years ago

Sorry it’s so many steps … try M-x hl-line-mode to disable hl-line, then M-: (face-at-point) again. Also, if you could do the other things I mentioned:

run M-: (display-color-cells) and show me the output, and
try running Emacs in GUI mode if possible, and see if the same problem occurs.

honza commented 11 years ago

esk-paren-face is the output of (face-at-point) with hl-line disabled.

256 (#o400, #x100)
Yes.

sellout commented 11 years ago

Ok, cool – esk-paren-face is from Emacs Starter Kit. I don’t have any faces defined for that. Just talked to @technomancy (author of emacs-starter-kit) about it, and he’s going to deprecate esk-paren-face in favor of paren-face, which Solarized already supports.

A workaround until @technomancy gets around to it is to find the line

             (paren-face ((t (,@fg-base01))))

in solarized-definitions.el and add

             (esk-paren-face ((t (,@fg-base01))))

below it (then you’ll have to load-theme again).

Let me know if that works for you.

honza commented 11 years ago

The phrase parent-face doesn't occur anywhere in this project's source code (master). I think I'll wait until the starter kit gets updated. Thanks!

sellout commented 11 years ago

paren, not parent, but hopefully @technomancy will get to it soon :)

honza commented 11 years ago

That's what I meant. I did actually search for the right thing :)

:sparkles: