search

sellout / emacs-color-theme-solarized

Emacs highlighting using Ethan Schoonover’s Solarized color scheme
http://ethanschoonover.com/solarized
MIT License
1.15k stars 201 forks source link

fix background color in 256-color terminals #85

Closed leifwalsh closed 9 years ago

leifwalsh commented 11 years ago

Fixes https://github.com/sellout/emacs-color-theme-solarized/issues/62 for me, maybe not the best way but it's been working for me in iterm2.

nyc commented 11 years ago

Works for me too on OSX using iTerm2. Thanks!

leifwalsh commented 11 years ago

This is still not working well for me in xterm or urxvt. I'll keep working on it.

Sent from my iPhone

On Mar 23, 2013, at 22:13, Nicholas Cho notifications@github.com wrote:

Works for me too on OSX using iTerm2. Thanks!

— Reply to this email directly or view it on GitHub.

creese commented 11 years ago

This is fixed in mwolson's fork. I'm running emacsclient in urxvt in tmux.

schober commented 11 years ago

Works great in iterm2. Please consider, @sellout! (Or suggest less hacky alternative...)

gguimaraesbr commented 10 years ago

Worked for me in iTerm2.

webframp commented 10 years ago

+1 this works well for me too

Peluko commented 10 years ago

+1, ok on iTerm + tmux

Edit 10 minutes after..... It works by solving the background issue, but at a closer look, some other colors are off. The solution for me was to use TERM=xterm-16color emacs without this patch.

minrockli commented 10 years ago

@sellout This fix also works for me. Otherwise, the color theme is broken. I ran emacs with --nw

sellout commented 9 years ago

The overhauled version of the code does something like this and should work as well.